Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a continuation of solving this issue, which was partially solved here. The PR introduces calculating matrix inverse that is optimized for 4x4 affine transformations. It's divided into three main parts: calculating determinant inverse, 3x3 matrix inverse, and translation inverse. The 3x3 matrix inverse calculation algorithm is based on David G. Simpson's implementation from Nasa https://caps.gsfc.nasa.gov/simpson/software/m33inv_f90.txt.
For now I've removed the part of the code that checks specifically for vertical and horizontal transformation, but I have an idea to bring it back in the
Invert
function, which could speed up in these cases (I think we can do the same for rotations).Currently, it's not possible to click on View outside of its parent bounds. I can add the check that will traverse down the tree if the component has any overflowing children.
Should I close my previous draft to this issue?
Cc: @realsoelynn
Changelog:
[IOS][FIXED] - inverting touch point in
findNodeAtPoint
Test Plan:
extended examples from this reproducer: https://github.com/realsoelynn/rn-inspectortools-transform-related-reproducer