Merge all the remaining .so libraries into libreactnative.so #46059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61376496 |
Summary: This moves other 2 libraries inside libreactnative.so Changelog: [Android] [Changed] - Move libyoga.so and libturbomodulejsijni.so inside libreactnative.so Differential Revision: D61376499
Summary: We have a bunch of prefab targets which are no longer necessary. I'm removing them all in this first round of cleanup Changelog: [Android] [Breaking] - Remove several unnecessary android prefab targets. Use ReactAndroid::reactnative instead Differential Revision: D61376497
Summary: This merges another library inside libreactnative.so Changelog: [Android] [Changed] - Merge libuimanagerjni.so inside libreactnative.so Differential Revision: D61376498
…k#46059) Summary: Pull Request resolved: facebook#46059 This merges all the remaining dynamic libraries into libreactnative.so. Sadly I couldn't split this in smaller diffs as all the libraries are connected with each other. I also had to introduce 2 other SOs: `libhermestooling.so` and `libjsctooling.so` which contains all the necessary libs used when loading either JSC or Hermes. They need to be isolated as RNGP will remove those libraries based on the library the user decides to pick. Changelog: [Android] [Breaking] - Merge all the remaining .so libraries into libreactnative.so Differential Revision: D61376496
|
This pull request was exported from Phabricator. Differential Revision: D61376496 |
cortinico
force-pushed
the
export-D61376496
branch
from
868f7e2
to
5fbe6d8
Compare
|
This pull request has been merged in db80d78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This merges all the remaining dynamic libraries into libreactnative.so.
Sadly I couldn't split this in smaller diffs as all the libraries are connected with each other.
I also had to introduce 2 other SOs:
libhermestooling.soandlibjsctooling.sowhich containsall the necessary libs used when loading either JSC or Hermes. They need to be isolated
as RNGP will remove those libraries based on the library the user decides to pick.
Changelog:
[Android] [Breaking] - Merge all the remaining .so libraries into libreactnative.so
Differential Revision: D61376496