Implement Runtime.releaseObject and releaseObjectGroup #46032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61280394 |
|
This pull request was exported from Phabricator. Differential Revision: D61280394 |
motiz88
force-pushed
the
export-D61280394
branch
from
873a4b6
to
174f166
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Aug 15, 2024
Summary: Pull Request resolved: facebook#46032 Changelog: [Internal] Implements the [`Runtime.releaseObject`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObject) and [`Runtime.releaseObjectGroup`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObjectGroup) CDP methods. These are used by CDT in a few places to release inspected objects (e.g. as part of the [popover](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/7b143e5d05a102c8c9cc7e282bab7b0751f75d61/front_end/panels/sources/DebuggerPlugin.ts#L766) feature), which is important to prevent memory leaks in long-running Fusebox sessions. Reviewed By: dannysu, robhogan Differential Revision: D61280394
Summary: Changelog: [Internal] Implements the [`Runtime.releaseObject`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObject) and [`Runtime.releaseObjectGroup`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObjectGroup) CDP methods. These are used by CDT in a few places to release inspected objects (e.g. as part of the [popover](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/7b143e5d05a102c8c9cc7e282bab7b0751f75d61/front_end/panels/sources/DebuggerPlugin.ts#L766) feature), which is important to prevent memory leaks in long-running Fusebox sessions. Reviewed By: dannysu, robhogan Differential Revision: D61280394
motiz88
force-pushed
the
export-D61280394
branch
from
174f166
to
0d84377
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61280394 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 10, 2024
Summary: X-link: facebook/react-native#46032 Changelog: [Internal] Implements the [`Runtime.releaseObject`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObject) and [`Runtime.releaseObjectGroup`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObjectGroup) CDP methods. These are used by CDT in a few places to release inspected objects (e.g. as part of the [popover](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/7b143e5d05a102c8c9cc7e282bab7b0751f75d61/front_end/panels/sources/DebuggerPlugin.ts#L766) feature), which is important to prevent memory leaks in long-running Fusebox sessions. Reviewed By: dannysu, robhogan Differential Revision: D61280394 fbshipit-source-id: 82181c6d0d6e52cf606ef2f48d389631e44b295e
|
This pull request has been merged in 4eceb7e. |
|
This pull request was successfully merged by @hoxyq in 4eceb7e When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Oct 11, 2024
Summary: Original Author: hoxy@meta.com Original Git: 2e2483e Original Reviewed By: dannysu, robhogan Original Revision: D61280394 X-link: facebook/react-native#46032 Changelog: [Internal] Implements the [`Runtime.releaseObject`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObject) and [`Runtime.releaseObjectGroup`](https://cdpstatus.reactnative.dev/devtools-protocol/tot/Runtime#method-releaseObjectGroup) CDP methods. These are used by CDT in a few places to release inspected objects (e.g. as part of the [popover](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/blob/7b143e5d05a102c8c9cc7e282bab7b0751f75d61/front_end/panels/sources/DebuggerPlugin.ts#L766) feature), which is important to prevent memory leaks in long-running Fusebox sessions. Reviewed By: fbmal7 Differential Revision: D64202109 fbshipit-source-id: 77baac1a3bbddd9d6c4e7348e5bfb38d847a55f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Implements the
Runtime.releaseObjectandRuntime.releaseObjectGroupCDP methods. These are used by CDT in a few places to release inspected objects (e.g. as part of the popover feature), which is important to prevent memory leaks in long-running Fusebox sessions.Reviewed By: robhogan
Differential Revision: D61280394