Add option to resolve all asset scales for sources #45989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45989 Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image. Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio. ## Changelog [General][Added] Capability to resolve specific asset scale Differential Revision: D61172622
rozele
force-pushed
the
export-D61172622
branch
from
ec39f9c
to
3dd06ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
rozele
force-pushed
the
export-D61172622
branch
from
3dd06ff
to
51e9705
Compare
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45989 Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image. Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio. ## Changelog [General][Added] Capability to resolve specific asset scale Differential Revision: D61172622
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45989 Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image. Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio. ## Changelog [General][Added] Capability to resolve specific asset scale Differential Revision: D61172622
rozele
force-pushed
the
export-D61172622
branch
from
51e9705
to
103e53c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
rozele
added a commit
to rozele/react-native-macos
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#45989 Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image. Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio. ## Changelog [General][Added] Capability to resolve specific asset scale Differential Revision: D61172622
rozele
force-pushed
the
export-D61172622
branch
from
103e53c
to
347341e
Compare
Summary: Pull Request resolved: facebook#45989 Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image. Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio. ## Changelog [General][Added] Capability to resolve specific asset scale Differential Revision: D61172622
|
This pull request was exported from Phabricator. Differential Revision: D61172622 |
rozele
force-pushed
the
export-D61172622
branch
from
347341e
to
9cc515f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some React Native platforms have multiple display resolutions to contend with. In such cases, the PixelRatio API, which assumes a single display resolution value for the whole app, does not correctly resolve the scale for a particular Image.
Adding an API to resolve each scale variant to a packaged asset allows other platforms to override the Image component to pass all scale options to the Image native component, rather than only the one matching the value from PixelRatio.
Changelog
[General][Added] Capability to resolve specific asset scale
Differential Revision: D61172622