-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding space to $(inherited) string to avoid merging of inherited and… #45520
Conversation
… folly_compiler_flags
Hi @nikhiltekwani09! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@arushikesarwani94 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@arushikesarwani94 merged this pull request in be93092. |
This pull request was successfully merged by @nikhiltekwani09 in be93092 When will my fix make it into a release? | How to file a pick request? |
@arushikesarwani94 will this be available in release 0.74, I m currently blocked due to this |
#45520) Summary: Added space to $(inherited) string to avoid creation of wrong cpp flags in RCTAppDelegate podspec <img width="1157" alt="Screenshot 2024-07-18 at 8 51 19 PM" src="https://github.com/user-attachments/assets/29d32d08-e81f-4c25-b8ee-5dccc0f620ea"> ## Changelog: [IOS] [FIXED] - Building of iOS project when RCTAppDelegate is used in the project Pull Request resolved: #45520 Test Plan: To test this you can simply change in your node modules and run pod install, the build will now work successfully Reviewed By: cipolleschi Differential Revision: D59950906 Pulled By: arushikesarwani94 fbshipit-source-id: 0d58620aa0be7ac4fcbcd309f06df0eef7844016
#45520) Summary: Added space to $(inherited) string to avoid creation of wrong cpp flags in RCTAppDelegate podspec <img width="1157" alt="Screenshot 2024-07-18 at 8 51 19 PM" src="https://github.com/user-attachments/assets/29d32d08-e81f-4c25-b8ee-5dccc0f620ea"> ## Changelog: [IOS] [FIXED] - Building of iOS project when RCTAppDelegate is used in the project Pull Request resolved: #45520 Test Plan: To test this you can simply change in your node modules and run pod install, the build will now work successfully Reviewed By: cipolleschi Differential Revision: D59950906 Pulled By: arushikesarwani94 fbshipit-source-id: 0d58620aa0be7ac4fcbcd309f06df0eef7844016
Summary:
Added space to $(inherited) string to avoid creation of wrong cpp flags in RCTAppDelegate podspec
Changelog:
[IOS] [FIXED] - Building of iOS project when RCTAppDelegate is used in the project
Test Plan
To test this you can simply change in your node modules and run pod install, the build will now work successfully