Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Fixes findNodeAtPoint when views were inverted #45519

Closed
wants to merge 5 commits into from
Closed

[Fabric] Fixes findNodeAtPoint when views were inverted #45519

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d24c221
[Fabric] Fixes findNodeAtPoint when views were inverted
zhongwuzw Jul 18, 2024
b064d65
handle rotate inversion
zhongwuzw Jul 24, 2024
3aa37d5
Add test
zhongwuzw Jul 30, 2024
ed166f9
update
zhongwuzw Aug 15, 2024
60de02f
Merge commit '17017d2b8181acf6e1ce6543f333cd6653b6945b' into features…
zhongwuzw Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@zhongwuzw
zhongwuzw committed Aug 15, 2024
commit ed166f9cca81fed6cca650ed63d215e6fe9594fb
11 changes: 6 additions & 5 deletions packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,12 @@ ShadowNode::Shared LayoutableShadowNode::findNodeAtPoint(
auto transformedFrame = frame * transform;
auto isPointInside = transformedFrame.containsPoint(point);

if (!isPointInside) {
return nullptr;
} else if (!layoutableShadowNode->canChildrenBeTouchTarget()) {
return node;
}

if (Transform::isVerticalInversion(transform) ||
Transform::isHorizontalInversion(transform)) {
auto centerX =
Expand All @@ -286,11 +292,6 @@ ShadowNode::Shared LayoutableShadowNode::findNodeAtPoint(
point.x = centerX + relativeX;
point.y = centerY + relativeY;
}
if (!isPointInside) {
return nullptr;
} else if (!layoutableShadowNode->canChildrenBeTouchTarget()) {
return node;
}

auto newPoint = point - transformedFrame.origin -
layoutableShadowNode->getContentOriginOffset(false);
Expand Down
Loading