fix:dead lock between EventDispatcherImpl.moveStagedEventsToDispatchQueue and EventDispatcherImpl.dispatchEvent #45428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueue and EventDispatcherImpl.dispatchEvent
facebook-github-bot
added
the
CLA Signed
|
anyone see here? |
facebook-github-bot
added
the
Shared with Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fix:dead lock between EventDispatcherImpl.moveStagedEventsToDispatchQueue and EventDispatcherImpl.dispatchEvent when project fabric global switch is on, bridgeLess switch is off, but the rn page set fabric is false when new RootView.
Changelog:
[ANDROID] [FIXED] - When we try to use fabric without bridgeLess, but start rn pages with non fabric flag in RootView, a dead lock problem was happened. mEventsStagingLock and mEventsToDispatchLock in EventDispatcherImpl.java was kept by different threads, which causes a dead lock. To solve it, the lock keep order in method moveStagedEventsToDispatchQueue need to be changed.
The detailed log was attached below:
"main" prio=5 tid=1 Blocked
| group="main" sCount=1 ucsCount=0 flags=1 obj=0x7203fbf8 self=0xb400007c88210800
| sysTid=6058 nice=-10 cgrp=default sched=0/0 handle=0x7d30529500
| state=S schedstat=( 11035776042 761324895 8347 ) utm=924 stm=178 core=7 HZ=100
| stack=0x7fccd93000-0x7fccd95000 stackSize=8188KB
| held mutexes=
at com.facebook.react.uimanager.events.EventDispatcherImpl.moveStagedEventsToDispatchQueue(EventDispatcherImpl.java:206)
at com.facebook.react.uimanager.events.EventDispatcherImpl.-$$Nest$mmoveStagedEventsToDispatchQueue(unavailable:0)
at com.facebook.react.uimanager.events.EventDispatcherImpl$ScheduleDispatchFrameCallback.doFrame(EventDispatcherImpl.java:297)
at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:180)
at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:87)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1403)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1413)
at android.view.Choreographer.doCallbacks(Choreographer.java:1040)
at android.view.Choreographer.doFrame(Choreographer.java:920)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1388)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:240)
at android.os.Looper.loop(Looper.java:351)
at android.app.ActivityThread.main(ActivityThread.java:8423)
at java.lang.reflect.Method.invoke(Native method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:584)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
"mqt_js" prio=5 tid=110 Blocked
| group="main" sCount=1 ucsCount=0 flags=1 obj=0x19a133d0 self=0x7c69fad000
| sysTid=6773 nice=0 cgrp=default sched=0/0 handle=0x7b779d3cb0
| state=S schedstat=( 4339245852 571596595 5454 ) utm=391 stm=42 core=4 HZ=100
| stack=0x7b778d0000-0x7b778d2000 stackSize=1039KB
| held mutexes=
at com.facebook.react.uimanager.events.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:125)
at com.facebook.react.fabric.interop.InteropEventEmitter.receiveEvent(InteropEventEmitter.java:58)
at com.facebook.react.uimanager.events.ReactEventEmitter.receiveEvent(ReactEventEmitter.java:153)
at com.facebook.react.uimanager.events.ReactEventEmitter.receiveEvent(ReactEventEmitter.java:72)
at com.facebook.react.uimanager.events.ReactEventEmitter.receiveEvent(ReactEventEmitter.java:65)
at com.facebook.react.uimanager.events.Event.dispatch(Event.java:170)
at com.facebook.react.uimanager.events.Event.dispatchModern(Event.java:215)
at com.facebook.react.uimanager.events.EventDispatcherImpl$DispatchEventsRunnable.run(EventDispatcherImpl.java:376)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:30)
at android.os.Looper.loopOnce(Looper.java:240)
at android.os.Looper.loop(Looper.java:351)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:236)
at java.lang.Thread.run(Thread.java:1012)
Test Plan:
After we change that, the dead lock will not be happened again.