Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android autolink plugin for libraries that are platform specific #45223

Conversation

gabrieldonadel
Copy link
Collaborator

Summary:

Fixes #45222

Changelog:

[ANDROID] [FIXED] - Fix autolink plugin for libraries that are platform-specific

Test Plan:

And a library that does not have Android native code such as @react-native-segmented-control/segmented-control and sync gradle

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jun 28, 2024
@cortinico
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the @gabrieldonadel/fix-android-autolink branch from f57b142 to 123f721 Compare July 1, 2024 11:18
@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cortinico
Copy link
Contributor

Great fix @gabrieldonadel

I've actually included tests + used a .filter{} in your solution as it's a bit more idiomatic. You'll see it once it lands.

@cortinico
Copy link
Contributor

Pick request is here: reactwg/react-native-releases#351

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,366,097 -7
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,562,900 -8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c7988c9
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 1, 2024
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 20521cc.

Copy link

github-actions bot commented Jul 1, 2024

This pull request was successfully merged by @gabrieldonadel in 20521cc.

When will my fix make it into a release? | How to file a pick request?

@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-android-autolink branch July 1, 2024 12:16
cortinico pushed a commit that referenced this pull request Jul 1, 2024
…45223)

Summary:
Fixes #45222

## Changelog:

[ANDROID] [FIXED] - Fix autolink plugin for libraries that are platform-specific

Pull Request resolved: #45223

Test Plan: And a library that does not have Android native code such as react-native-segmented-control/segmented-control and sync gradle

Reviewed By: rshest

Differential Revision: D59221562

Pulled By: cortinico

fbshipit-source-id: 55739d63ded63e46897d0d770281f937668c1f50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autolinkLibrariesFromCommand fails if a library does not contain an android specific config
4 participants