[iOS] Fixes TextInput crash when undo if text longer than maxLength

[zhongwuzw]

Summary:

Fixes #45050 . System pass the range bigger than we allowed because we limit the maxLength. We truncated the range to fix the undo crash.

cc. @cortinico .

Changelog:

[IOS] [FIXED] - Fixes TextInput crash when undo if text longer than maxLength

Test Plan:

Repro please see #45050.

[cipolleschi]

@zhongwuzw thanks for the contribution.
I'm not super familiar with the component internals, but I left a comment to get more clarity.

Also, does this work with both architectures?

[cipolleschi]

Shouldn't it be something like this?

Suggested change

	if (range.location + range.length > _backedTextInputView.text.length) {
	range = NSMakeRange(range.location, _backedTextInputView.text.length - range.location);
	} else if ([newText isEqualToString:text]) {
	if (range.location + range.length > _backedTextInputView.text.length) {
	range = NSMakeRange(range.location, _backedTextInputView.text.length - range.location);
	}
	if ([newText isEqualToString:text]) {

I'm not super familiar with the internals, but in the first branch, we are updating the range and the second branch don't do anything related to range, so it feels weird that we have a logic that is:

// if range is greater that the backed text length
// then do something
// else if the text has not changed, 
// then do something else.

the value of range and the comparison between newText and text are unrelated no?

[zhongwuzw]

@cipolleschi Yes, it works with both architectures.
The reason is if the range is bigger than text input's text range, we can't check whether the text changed, it may return YES to let the system change the text input and lead to crash, instead we should skip the text equal check and replace the text input by ourself.

[cipolleschi]

could you rebase on top of main, please? 🙏
CI is red, but we have been working on it in the past days, so now it should be fixed.

[zhongwuzw]

@cipolleschi Updated :)

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	20,478,732	-5
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	23,676,531	+8
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 6bb75c7
Branch: main

[facebook-github-bot]

@cipolleschi merged this pull request in 9b9c780.

[github-actions]

This pull request was successfully merged by @zhongwuzw in 9b9c780.

^{When will my fix make it into a release? | How to file a pick request?}