Migrate ReactHost / ReactInstanceManager destroy() call sites to use invalidate() #45082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58811091 |
Differential Revision: D58811090
|
This pull request was exported from Phabricator. Differential Revision: D58811091 |
motiz88
force-pushed
the
export-D58811091
branch
from
fb693b9
to
1afa646
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Jun 24, 2024
…invalidate() (facebook#45082) Summary: Pull Request resolved: facebook#45082 Changelog: [Android][Breaking] `ReactNativeHost` invalidates the instance manager on `clear()` Changes `ReactNativeHost.clear()` to invalidate the underlying `ReactInstanceManager`, rather than merely destroying the instance. This is technically a **breaking change** because the underlying `ReactInstanceManager` may have escaped (via `ReactNativeHost.getReactInstanceManager()`) before the `clear()` call. In my reading of the API and of usages like [this one in Expo](https://github.com/expo/expo/blob/23a905b17065703882ebeda1fc9f65a05cc69fa7/packages/expo-dev-menu-interface/android/src/main/java/expo/interfaces/devmenu/ReactHostWrapper.kt#L117), this should rarely occur in practice. The plan: 1. D58811090: Add the basic `invalidate()` functionality. 2. **[This diff]**: Add `invalidate()` call sites where it makes sense in core. 3. [Upcoming diff]: Keep the Fusebox debugging target registered until the Host is explicitly invalidated. Reviewed By: javache Differential Revision: D58811091
…invalidate() (facebook#45082) Summary: Pull Request resolved: facebook#45082 Changelog: [Android][Breaking] `ReactNativeHost` invalidates the instance manager on `clear()` Changes `ReactNativeHost.clear()` to invalidate the underlying `ReactInstanceManager`, rather than merely destroying the instance. This is technically a **breaking change** because the underlying `ReactInstanceManager` may have escaped (via `ReactNativeHost.getReactInstanceManager()`) before the `clear()` call. In my reading of the API and of usages like [this one in Expo](https://github.com/expo/expo/blob/23a905b17065703882ebeda1fc9f65a05cc69fa7/packages/expo-dev-menu-interface/android/src/main/java/expo/interfaces/devmenu/ReactHostWrapper.kt#L117), this should rarely occur in practice. The plan: 1. D58811090: Add the basic `invalidate()` functionality. 2. **[This diff]**: Add `invalidate()` call sites where it makes sense in core. 3. [Upcoming diff]: Keep the Fusebox debugging target registered until the Host is explicitly invalidated. Reviewed By: javache Differential Revision: D58811091
|
This pull request was exported from Phabricator. Differential Revision: D58811091 |
motiz88
force-pushed
the
export-D58811091
branch
from
1afa646
to
1e6420b
Compare
|
This pull request has been merged in 986cf18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Android][Breaking]
ReactNativeHostinvalidates the instance manager onclear()Changes
ReactNativeHost.clear()to invalidate the underlyingReactInstanceManager, rather than merely destroying the instance.This is technically a breaking change because the underlying
ReactInstanceManagermay have escaped (viaReactNativeHost.getReactInstanceManager()) before theclear()call. In my reading of the API and of usages like this one in Expo, this should rarely occur in practice.The plan:
invalidate()functionality.invalidate()call sites where it makes sense in core.Differential Revision: D58811091