Fix for Clang tidy, needed for fbcode include #44655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57721635 |
Summary: Required to compile with clang Differential Revision: D57721635
|
This pull request was exported from Phabricator. Differential Revision: D57721635 |
Base commit: 352d4b1 |
|
This pull request has been merged in c207708. |
|
This pull request was successfully merged by @jmavra in c207708. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Pull Request resolved: facebook#44655 Required to compile with clang This is because previously it was comparing size_t with int which is not allowed under compilation with clang Changelog: [Internal] [Fixed] - Replaced old style for loop with new style to avoid clang errors with size_t to int comparisons Differential Revision: D57721635 fbshipit-source-id: 2738f7b415d668c37536f7f93b2e0985fa2cc5e6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fix is required to be able to compile with clang, as one of the checks is comparison of int with size_t
Differential Revision: D57721635