[codegen] Fixes enum codegen value cases #44654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Thanks for the fix! Could you add unit test or make sure this scenario is captured in a snapshot? |
Base commit: e0a2e86 |
zhongwuzw
commented
May 24, 2024
| @@ -3,6 +3,9 @@ | |||
| <PROJECT_ROOT>/packages/react-native/template/.* | |||
| <PROJECT_ROOT>/packages/react-native/sdks/.* | |||
|
|
|||
| ; Ignore the codegen e2e tests | |||
| <PROJECT_ROOT>/packages/react-native-codegen/e2e/__test_fixtures__/modules/NativeEnumTurboModule.js | |||
There was a problem hiding this comment.
flow check failed https://app.circleci.com/pipelines/github/facebook/react-native/46812/workflows/f35b38a2-172b-4f7c-b041-57b63ca9692e/jobs/1524067. Seems // $FlowFixMe not work for SyntaxError.
|
@javache Thanks for the review. I added the snapshot test. |
…/fix_enum_codegen
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 1a1795a. |
|
This pull request was successfully merged by @zhongwuzw in 1a1795a. When will my fix make it into a release? | How to file a pick request? |
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
Summary: Fixes facebook#44632 ## Changelog: [GENERAL] [FIXED] - [codegen] Fixes enum codegen value cases Pull Request resolved: facebook#44654 Test Plan: facebook#44632 Reviewed By: cipolleschi, dmytrorykun Differential Revision: D58135645 Pulled By: cortinico fbshipit-source-id: 5c0634ef1d1d7375d2ecfcf7f916d67fd39b7300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #44632
Changelog:
[GENERAL] [FIXED] - [codegen] Fixes enum codegen value cases
Test Plan:
#44632