Fix/keyboard avoiding view #44652
Open
Fix/keyboard avoiding view #44652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hello @Gregoirevda the fix looks good, thanks. Do you have a code example where I could see the bug before and verify the fixed state? |
|
@Gregoirevda CI jobs are failing. Would you mind resolving those? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #36287
KeyboardAvoidingView will not work when mounted on a view which already has a visible keyboard
Test Plan
Open Keyboard, mount KeyboardAvoidingView and verify it's not centered.
Changelog:
[General] [Fixed] - KeyboardAvoidingView applied on mount when keyboard is shown