-
Notifications
You must be signed in to change notification settings - Fork 25.1k
update TypeScript dependencies #43987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update TypeScript dependencies to support TypeScript 5.4.
Base commit: eae5d97 |
|
Also add "typescript": "^5.4.4" to the package.json |
|
@joe-sam which package.json? This same one? If so, in which section? |
Not sure which ones probably at minimum the main react-native package.json and the template package.json and as far as I know these are all devDependencies sections and do not affect the runtime. Typescript has not been bumped up since last year and we could all benefit with some of the new semantics. Best avoid use the caret (^) as that might cause some unexpected compile problems later in the project lifetime. |
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@paulschreiber the Node that we have on CircleCI (v18.16.0) is incompatible with what's required this change (v18.18.0). We're currently discussing what to do about this. |
|
@dmytrorykun Should I update |
|
@paulschreiber I think let's wait until we land this. |
|
The difficult part with this sort of dependency change is the circular logic usually getting the types/react to sync to the react lib version bump and then in turn having to fix all the breaking change caused by having all the apps to follow suit. Since react 18 is already supported out of the box these type definition upgrades have already been made upto the latest major version release. I am already using typescript 5.4.4 with yarn tsc without bumping the parser plugins in an older react-native supported version and an IDE linter plugin, and have experienced no issues at all. In fact am happy to note some false positives in the linter were fixed with the update. |
|
What is this blocked on? |
|
Hey @robhogan do you know what is the latest on this? |
|
TypeScript 5.5.x is now out. |
|
Here is the blog announcing all the amazing benefits of upgrading straight upto typescript 5.5 for React Native developers ! |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
Summary:
Update TypeScript dependencies to support TypeScript 5.4.
TypeScript 5.4 support was added in eslint-plugin 7.2.0 Updating to current version (7.6.0).
Changelog:
[INTERNAL] [CHANGED] - Update @typescript-eslint modules.
Test Plan:
Run standard unit and integration tests.