Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scripted: Codemod ReactApplicationContext creators to BridgeReactContext #43626

Closed
wants to merge 3 commits into from
Closed

Scripted: Codemod ReactApplicationContext creators to BridgeReactContext #43626

wants to merge 3 commits into from

Commits on Mar 26, 2024

  1. Introduce BridgeReactContext < ReactApplicationContext 

    Summary:
Eventually, we will move all bridge methods to BridgeReactContext.

Long-term, ReactApplicationContext and ReactContext will become abstract. And these two contexts will only contain methods common to both modes.

Changelog: [Android][Added] Introduce BridgeReactContext

Differential Revision: https://internalfb.com/D55218592
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e00309c View commit details
    Browse the repository at this point in the history

  2. Manual: Codemod initializeWithInstance() callers to BridgeReactContext 

    Summary:
Eventaully, ReactApplicationContext.initailizeWithInstance() will be moved to BridgeReactContext.

Doing the migration up-front to remove noise from the eventual diff.

Changelog: [Internal]

Differential Revision: https://internalfb.com/D55218593
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    6f3f3ba View commit details
    Browse the repository at this point in the history

  3. Scripted: Codemod ReactApplicationContext creators to BridgeReactCont… 

    …ext (facebook#43626)

Summary:
Pull Request resolved: facebook#43626

The things that create ReactApplicationContext should instead create BridgeReactContext.

Long-term, ReactApplicationContext will be abstract. This diff pulls noise out from that eventual diff.

Changelog: [Internal]

Reviewed By: arushikesarwani94

Differential Revision: D55218591
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4cc95ef View commit details
    Browse the repository at this point in the history