Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Mar 18, 2024

Summary:
This is no longer used after switching to the new release workflow, which uses the newer and less error-prone set-version script.

Changelog: [Internal]

Differential Revision: D55027122

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55027122

@github-actions
Copy link

github-actions bot commented Mar 18, 2024

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 1dcd354

huntie added 2 commits March 19, 2024 05:09
Summary:

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D55027120
Summary:

This is no longer used after switching to the new release workflow, which uses the newer and less error-prone `set-version` script.

Changelog: [Internal]

Differential Revision: D55027122
@huntie huntie force-pushed the export-D55027122 branch from 9f866e8 to 1dcd354 Compare March 19, 2024 12:09
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55027122

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,125,875 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,491,236 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ebd170b
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 5a80935.

huntie added a commit that referenced this pull request Mar 20, 2024
Summary:
Pull Request resolved: #43534

This is no longer used after switching to the new release workflow, which uses the newer and less error-prone `set-version` script.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D55027122

fbshipit-source-id: faa8cfd2af9b54fab611b108df162793c5768695
This was referenced Jun 28, 2024
@huntie huntie deleted the export-D55027122 branch September 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants