Refactor ReactDelegate to provide DevSupportManager #43520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54967130 |
Summary: Refactor ReactDelegate to have a private `getDevSupportManager()` that can also be re-used by `reload()` This method conditionally provides the correct DevSupportManager in cases of Bridge & Bridgeless Changelog: [Internal] internal Differential Revision: D54967130
arushikesarwani94
force-pushed
the
export-D54967130
branch
from
b728d88 to
8f1d8d0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54967130 |
Base commit: f2f62cd |
Contributor
|
This pull request has been merged in 6dd0cc9. |
cortinico
pushed a commit
that referenced
this pull request
Mar 25, 2024
Summary: Pull Request resolved: #43520 Refactor ReactDelegate to have a private `getDevSupportManager()` that can also be re-used by `reload()` This method conditionally provides the correct DevSupportManager in cases of Bridge & Bridgeless Changelog: [Internal] internal Reviewed By: cortinico Differential Revision: D54967130 fbshipit-source-id: 37d585de33a50b98d01803d3080c5693a8c494b9
This was referenced Apr 5, 2024
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 30, 2024
Summary: In facebook#43520, this was moved to supply with the relevant DevSupportManager, however in Bridge mode in case of RELEASE(useDeveloperSupport = false), it would not provide BridgeDevSupportManager because of this check. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Differential Revision: D56739764
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 30, 2024
Summary: In facebook#43520, this was moved to supply with the relevant DevSupportManager, however in Bridge mode in case of RELEASE(useDeveloperSupport = false), it would not provide BridgeDevSupportManager because of this check. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Differential Revision: D56739764
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 30, 2024
Summary: In facebook#43520, this was moved to supply with the relevant DevSupportManager, however in Bridge mode in case of RELEASE(useDeveloperSupport = false), it would not provide BridgeDevSupportManager because of this check. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Differential Revision: D56739764
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 30, 2024
Summary: In facebook#43520, this was moved to supply with the relevant DevSupportManager, however this check for `useDeveloperSupport` is already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263 https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70 Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Reviewed By: javache Differential Revision: D56739764
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Apr 30, 2024
Summary: In facebook#43520, this was moved to supply with the relevant DevSupportManager, however this check for `useDeveloperSupport` is already part of https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java#L263 https://github.com/facebook/react-native/blob/0.74-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.java#L68-L70 Having this check here was causing early exit for Bridge RELEASE mode instead of returning the ReleaseDevSupportManager. Changelog: [ANDROID][FIXED] - Fixed `getDevSupportManager()` in ReactDelegate Reviewed By: javache Differential Revision: D56739764
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactor ReactDelegate to have a private
getDevSupportManager()that can also be re-used byreload()This method conditionally provides the correct DevSupportManager in cases of Bridge & Bridgeless
Changelog:
[Internal] internal
Differential Revision: D54967130