Fix clipping children in scroll views #43464
Closed
+247
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…ilters (facebook#43357) Summary: This diff adds a class to get the needed RenderEffects to support CSS filters on Android. This diff does not add any of the plumbing for it to actually work, that comes in the next diff, but I figured this was complicated and isolated enough to be on its own. Note that I did not add blur or drop shadow as those are a bit more involved and I plan on adding them later. Changelog: [Internal] Reviewed By: javache Differential Revision: D54603892
Summary: While working on filters I noticed that my blurred image was cropped on the scrollview. Setting `overflow: visible` for `contentContainerStyle` did not change anything. Turns out we do not call `setClipChildren(false)` like we do with [ReactViewGroup](https://www.internalfb.com/code/fbsource/[93517723586c]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java?lines=145). Changelog: [Internal] Differential Revision: D54640466
joevilches
force-pushed
the
export-D54640466
branch
from
39a09f7 to
811e933
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54640466 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54640466 |
Contributor
|
This pull request has been merged in 50d587b. |
j-piasecki
added a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Jul 30, 2024
…3017) ## Description In facebook/react-native#43464 `clipChildren` started being set to false on scrollviews, which caused `isViewClippingChildren` to return false. Because of this, gesture handler would traverse the children of the scrollview even when touch was out of bounds: https://github.com/user-attachments/assets/6d108b55-6e06-4202-bc77-9d9dd2825456 This PR adds special cases for scroll views that have `overflow` set to `visible` so that scrolling works on all of its children. ## Test plan Test components sample on FabricExample app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While working on filters I noticed that my blurred image was cropped on the scrollview. Setting
overflow: visibleforcontentContainerStyledid not change anything. Turns out we do not callsetClipChildren(false)like we do with ReactViewGroup.Changelog: [Internal]
Differential Revision: D54640466