Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen step to generate Custom RCTURLRequest Handlers #42923

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This change add the codegen step to generate the list of classes that can be used as custom URLHandlers

Changelog

[iOS][Added] - Add the codegen step to generate custom URLHandlers

Differential Revision: D53441411

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Feb 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

@cipolleschi cipolleschi force-pushed the export-D53441411 branch 2 times, most recently from 5e4cf23 to f6f10e8 Compare February 8, 2024 14:57
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 8, 2024
…42923)

Summary:

This change add the codegen step to generate the list of classes that can be used as custom URLHandlers

## Changelog
[iOS][Added] - Add the codegen step to generate custom URLHandlers

Differential Revision: D53441411
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

@analysis-bot
Copy link

analysis-bot commented Feb 8, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,246,944 +4
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,609,343 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 922fe91
Branch: main

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 9, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Differential Revision: D53441411
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 9, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Differential Revision: D53441411
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 12, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Differential Revision: D53441411
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53441411

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 12, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Reviewed By: RSNara

Differential Revision: D53441411
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 13, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Reviewed By: RSNara

Differential Revision: D53441411
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 13, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Reviewed By: RSNara

Differential Revision: D53441411
@cipolleschi cipolleschi force-pushed the export-D53441411 branch 2 times, most recently from fe65af3 to a61e2f6 Compare February 13, 2024 13:35
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Feb 13, 2024
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Reviewed By: RSNara

Differential Revision: D53441411
…e protocols (facebook#42923)

Summary:

This Diff implement the logic to:
- Read some lists of class names provided by libraries that conforms to some protocols we defined as extension points.
- Generate a provider in the React-Codegen podspec, whose code lives alongside the app code.
- Glue the app and the generated code together, allowing to link custom protocols

## Changelog
[iOS][Added] - Allow libraries to provide module which conforms to protocols meant to be extension points.

Reviewed By: RSNara

Differential Revision: D53441411
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 46d7f8a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants