Fix event emits during initial rendering in Fabric #42777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53108114 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 1, 2024
Summary: During view preallocation eventEmitter information is not being passed to the platform. This causes bugs with emision of events during initial rendering when using the new Fabric Event dispatching system. e.g. Rendering a TextInput that has 'onFocus' event and also has autoFocus enabled. The new Fabric Event dispatching system dispatch events earlier (this is expected) In this diff I'm fixing this issue by ensuring that all preallocated views have an eventEmitter (when its shadowNode has an eventEmitter) This was actually implemented in the past, but in order to optimize, we run an experiment (D29117957) and it was later deleted. (D40356386). I didn't find details of the results of the experiment. We could run another experiment to understand potential negative perf impact of this change, although I believe it's the right thing to do here. Changelog: [Android][Fixed] Fix delivery of events during initial rendering in new architecture Reviewed By: sammy-SC Differential Revision: D53108114
mdvacca
force-pushed
the
export-D53108114
branch
from
564911c
to
1e97584
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53108114 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 1, 2024
Summary: During view preallocation eventEmitter information is not being passed to the platform. This causes bugs with emision of events during initial rendering when using the new Fabric Event dispatching system. e.g. Rendering a TextInput that has 'onFocus' event and also has autoFocus enabled. The new Fabric Event dispatching system dispatch events earlier (this is expected) In this diff I'm fixing this issue by ensuring that all preallocated views have an eventEmitter (when its shadowNode has an eventEmitter) This was actually implemented in the past, but in order to optimize, we run an experiment (D29117957) and it was later deleted. (D40356386). I didn't find details of the results of the experiment. We could run another experiment to understand potential negative perf impact of this change, although I believe it's the right thing to do here. Changelog: [Android][Fixed] Fix delivery of events during initial rendering in new architecture Reviewed By: sammy-SC Differential Revision: D53108114
mdvacca
force-pushed
the
export-D53108114
branch
from
1e97584
to
d1df911
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53108114 |
Base commit: ebc2831 |
Summary: During view preallocation eventEmitter information is not being passed to the platform. This causes bugs with emision of events during initial rendering when using the new Fabric Event dispatching system. e.g. Rendering a TextInput that has 'onFocus' event and also has autoFocus enabled. The new Fabric Event dispatching system dispatch events earlier (this is expected) In this diff I'm fixing this issue by ensuring that all preallocated views have an eventEmitter (when its shadowNode has an eventEmitter) This was actually implemented in the past, but in order to optimize, we run an experiment (D29117957) and it was later deleted. (D40356386). I didn't find details of the results of the experiment. We could run another experiment to understand potential negative perf impact of this change, although I believe it's the right thing to do here. Changelog: [Android][Fixed] Fix delivery of events during initial rendering in new architecture Reviewed By: sammy-SC Differential Revision: D53108114
mdvacca
force-pushed
the
export-D53108114
branch
from
d1df911
to
efe5849
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53108114 |
|
This pull request has been merged in 7b36233. |
|
This pull request has been reverted by cc2a73a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
During view preallocation eventEmitter information is not being passed to the platform. This causes bugs with emision of events during initial rendering when using the new Fabric Event dispatching system.
e.g. Rendering a TextInput that has 'onFocus' event and also has autoFocus enabled.
The new Fabric Event dispatching system dispatch events earlier (this is expected)
In this diff I'm fixing this issue by ensuring that all preallocated views have an eventEmitter (when its shadowNode has an eventEmitter)
This was actually implemented in the past, but in order to optimize, we run an experiment (D29117957) and it was later deleted.
(D40356386). I didn't find details of the results of the experiment.
We could run another experiment to understand potential negative perf impact of this change, although I believe it's the right thing to do here.
Changelog: [Android][Fixed] Fix delivery of events during initial rendering in new architecture
Reviewed By: sammy-SC
Differential Revision: D53108114