Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for (de)serializing node state #42751

Closed
wants to merge 2 commits into from

Conversation

joevilches
Copy link
Contributor

Differential Revision: D53206323

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53206323

Copy link

github-actions bot commented Jan 31, 2024

Fails
🚫

❔ This pull request needs a description.

Generated by 🚫 dangerJS against 5c50283

joevilches added a commit to joevilches/yoga that referenced this pull request Jan 31, 2024
Summary:
X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323

fbshipit-source-id: 315c0e8837062788d5c54d22bf0f193bd237527e
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53206323

joevilches added a commit to joevilches/react-native that referenced this pull request Feb 8, 2024
Summary:
X-link: facebook/yoga#1570


tsia. Need node state

Differential Revision: D53206323
joevilches added a commit to joevilches/react-native that referenced this pull request Feb 8, 2024
Summary:
X-link: facebook/yoga#1570


tsia. Need node state

Differential Revision: D53206323
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53206323

joevilches added a commit to joevilches/yoga that referenced this pull request Feb 8, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Differential Revision: D53206323
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,233,799 +100
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,600,235 +115
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e37da1e
Branch: main

joevilches added a commit to joevilches/react-native that referenced this pull request Feb 9, 2024
Summary:
X-link: facebook/yoga#1570


tsia. Need node state

Reviewed By: NickGerleman

Differential Revision: D53206323
joevilches added a commit to joevilches/yoga that referenced this pull request Feb 9, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Reviewed By: NickGerleman

Differential Revision: D53206323
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53206323

Summary:
X-link: facebook/yoga#1571


tsia. This is state we need to capture as it can drastically affect the benchmark times

Reviewed By: NickGerleman

Differential Revision: D53203385
Summary:
X-link: facebook/yoga#1570


tsia. Need node state

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D53206323
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53206323

joevilches added a commit to joevilches/yoga that referenced this pull request Feb 9, 2024
Summary:

X-link: facebook/react-native#42751

tsia. Need node state

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D53206323
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Feb 10, 2024
Summary:
Pull Request resolved: #1570

X-link: facebook/react-native#42751

tsia. Need node state

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D53206323

fbshipit-source-id: eb48c3873536eb52c8ffcce8005725da274e5373
facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Feb 10, 2024
Summary:
X-link: facebook/yoga#1570

X-link: facebook/react-native#42751

tsia. Need node state

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D53206323

fbshipit-source-id: eb48c3873536eb52c8ffcce8005725da274e5373
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 10, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ee21b85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants