Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Remove ATS config patch from react_native_post_install #42637

Closed

Conversation

gabrieldonadel
Copy link
Collaborator

Summary:

This PR removes the apply_ats_config function of ReactNativePodsUtils that was used inside react_native_post_install because it was preventing users from configuring NSAllowsArbitraryLoads to true in their projects, especially when building in CI as the plist file would be reset after running pod install.

Changelog:

[IOS] [CHANGED] - Remove ATS config patch from react_native_post_install

Test Plan:

Edit Info.plist, run pod install and check if changes have not been overwritten

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 24, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

TY for submitting this PR!

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 25, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 41c601e.

@gabrieldonadel gabrieldonadel deleted the remove-ats-config-script branch January 25, 2024 12:47
blakef pushed a commit that referenced this pull request Jan 25, 2024
Summary:
This PR removes the `apply_ats_config` function of ReactNativePodsUtils that was used inside `react_native_post_install` because it was preventing users from configuring `NSAllowsArbitraryLoads` to true in their projects, especially when building in CI as the plist file would be reset after running pod install.

[IOS] [CHANGED] - Remove ATS config patch from react_native_post_install

Pull Request resolved: #42637

Test Plan: Edit `Info.plist`, run `pod install` and check if changes have not been overwritten

Reviewed By: cortinico

Differential Revision: D53048299

Pulled By: cipolleschi

fbshipit-source-id: 8dc335fae2e05a62daf931a50fa3f7a314e76a2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants