Add a snapshot only if the Modal is visible #42619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53003657 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Differential Revision: D53003657
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Differential Revision: D53003657
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Differential Revision: D53003657
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Differential Revision: D53003657
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Differential Revision: D53003657
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Reviewed By: sammy-SC Differential Revision: D53003657
cipolleschi
force-pushed
the
export-D53003657
branch
from
ba3d885
to
8e048c4
Compare
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Reviewed By: sammy-SC Differential Revision: D53003657
|
This pull request was exported from Phabricator. Differential Revision: D53003657 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
Summary: This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly ## Changelog [iOS][Changed] - Add the for the dismissal snapshot only when we need it. Reviewed By: sammy-SC Differential Revision: D53003657
cipolleschi
force-pushed
the
export-D53003657
branch
from
8e048c4
to
01abca7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53003657 |
|
This pull request has been merged in 7c4afa1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a workaround to prepare for the next diff in the stack and make sure that the modal works correctly
Changelog
[iOS][Changed] - Add the for the dismissal snapshot only when we need it.
Differential Revision: D53003657