Rename AbsolutePositioning errata #42318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 17, 2024
Summary: X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Differential Revision: D52820117 fbshipit-source-id: 5b0461d446e25ca5806652b89c9ef30921b8c3f5
joevilches
force-pushed
the
export-D52820117
branch
from
a15ac7c
to
b8aa4e0
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 17, 2024
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Differential Revision: D52820117
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 17, 2024
Summary: Pull Request resolved: facebook#1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Differential Revision: D52820117 fbshipit-source-id: 7f306a32022de8cbf38734597a68effe358293b6
Base commit: f30f867 |
joevilches
force-pushed
the
export-D52820117
branch
from
b8aa4e0
to
34d6309
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 18, 2024
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
force-pushed
the
export-D52820117
branch
from
34d6309
to
517bb52
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 18, 2024
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
force-pushed
the
export-D52820117
branch
from
517bb52
to
396b1a4
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 18, 2024
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 18, 2024
Summary: Pull Request resolved: facebook#1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117 fbshipit-source-id: 21a70973155bb37e437ca4754e746fdae928af21
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 18, 2024
Summary: Pull Request resolved: facebook#1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117 fbshipit-source-id: f4d82790d3c9aa555f28882fb0e2939c88ad6069
joevilches
force-pushed
the
export-D52820117
branch
from
396b1a4
to
85b0788
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jan 18, 2024
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs bypass-github-export-checks Reviewed By: NickGerleman Differential Revision: D52820117
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
…feature to false (facebook#42253) Summary: X-link: facebook/yoga#1549 This experimental feature is always false, and with the next diff I will be deleting the branch that actually calls into this. Separating this diff out to simplify the review process. bypass-github-export-checks Reviewed By: NickGerleman Differential Revision: D52705765
Summary: X-link: facebook/yoga#1556 Since we aim to ship static to all users of yoga (not just XPR), we need to remove the errata that is gating most of the features. This should be a non breaking change. To ensure that, I added a new errata which, if on, will use the inner size of the containing node as the containing block. This is how it has been for a while and resolving this is risky and time consuming so for the time being we will stick with that. bypass-github-export-checks Reviewed By: NickGerleman Differential Revision: D52706161
…2316) Summary: We need to change the typing to allow for 'static'. An issue here is that Paper will not have `static` due to missing z-index logic. Unfortunately, we cannot create a fabric-only version of the typing as we cannot have conditional elements of the same name in ts. To remedy this we took out the parsing of the string 'static' in Paper. Instead we will just emit a warning and default to `relative`. bypass-github-export-checks Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D51431524
…k#42317) Summary: Added a complicated zIndex test and corresponding screenshot test for it. bypass-github-export-checks Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D52439963
Summary: X-link: facebook/yoga#1558 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs bypass-github-export-checks Reviewed By: NickGerleman Differential Revision: D52820117
joevilches
force-pushed
the
export-D52820117
branch
from
85b0788
to
3d8b97b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52820117 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Jan 18, 2024
Summary: Pull Request resolved: facebook#1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs bypass-github-export-checks Reviewed By: NickGerleman Differential Revision: D52820117 fbshipit-source-id: e6046c33ad89575c517bc71cff265f4e6b50fc89
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Jan 19, 2024
Summary: Pull Request resolved: #1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117 fbshipit-source-id: 80b77832baf65e68e57ca523c418422dd346ef0f
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jan 19, 2024
Summary: X-link: facebook/yoga#1558 X-link: facebook/react-native#42318 AbsolutePositioning -> AbsolutePositioningCatchAll A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs Reviewed By: NickGerleman Differential Revision: D52820117 fbshipit-source-id: 80b77832baf65e68e57ca523c418422dd346ef0f
|
This pull request has been merged in 08eb985. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AbsolutePositioning -> AbsolutePositioningCatchAll
A bit more clear. This errata is for various issues with positioning absolute nodes. There really isn't a clear description as to what specifically this enables/disables, so I just opted to say "catch all" to indicate that this controls various bugs
Differential Revision: D52820117