Fix retrieving current appearance in multi-window apps #42231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
requested changes
Jan 12, 2024
cipolleschi
approved these changes
Jan 16, 2024
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in d00d35e. |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
May 22, 2024
Summary: This PR resolves issues with retrieving appearance in multi-window apps by calling `RCTKeyWindow()` instead of retrieving the AppDelegate window property. It also does small optimization in the RCTAlertController. [IOS] [FIXED] - Fix retrieving current appearance in multi-window apps Pull Request resolved: facebook#42231 Test Plan: CI Green, it should work the same as before Reviewed By: NickGerleman Differential Revision: D52802756 Pulled By: cipolleschi fbshipit-source-id: 60b5f7045f41be19caae5102f0dc321d4ecdcd2f
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
May 22, 2024
Summary: This PR resolves issues with retrieving appearance in multi-window apps by calling `RCTKeyWindow()` instead of retrieving the AppDelegate window property. It also does small optimization in the RCTAlertController. [IOS] [FIXED] - Fix retrieving current appearance in multi-window apps Pull Request resolved: facebook#42231 Test Plan: CI Green, it should work the same as before Reviewed By: NickGerleman Differential Revision: D52802756 Pulled By: cipolleschi fbshipit-source-id: 60b5f7045f41be19caae5102f0dc321d4ecdcd2f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR resolves issues with retrieving appearance in multi-window apps by calling
RCTKeyWindow()instead of retrieving the AppDelegate window property. It also does small optimization in the RCTAlertController.Changelog:
[IOS] [FIXED] - Fix retrieving current appearance in multi-window apps
Test Plan:
CI Green, it should work the same as before