-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix New Arch build failing with -std=c++20
#42138
Conversation
Closed by accident. |
I suspect this is a C++ 20 thing instead of an XCode 15 thing. At least that bit of code is known to have a compat issue there. But older versions of RN shouldn’t be using that. |
I think you're right. Still, there will be cases where the hosting app itself may be using C++20 and including some headers from |
Yeah, the underlying fix is good. It might be worth updating commit title/message/changelog to be about fixing C++ 20 compat, instead of XCode 15, for posterity/recordkeeping. |
-std=c++20
Looks like there are some unrelated failures, but otherwise, it seems like we have consensus on merging this. |
Summary:
React-Fabric
fails to build because implicit constructors are no longer generated.This was fixed in 0.73 here: e1876af#diff-696b8d801910a87b0ba34645cfefcf01238c3f670d0e956a274091a6c950cc12
Changelog:
[IOS] [FIXED] -
React-Fabric
fails to build with-std=c++20
because implicit constructors are no longer generatedTest Plan:
n/a