Add Float and Int type support for Android modules #42126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52420921 |
Base commit: b81a081 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 3, 2024
Summary: This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Differential Revision: D52420921
dmytrorykun
force-pushed
the
export-D52420921
branch
from
9be2c6e
to
5586b35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52420921 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 3, 2024
Summary: This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Reviewed By: cipolleschi Differential Revision: D52420921
dmytrorykun
force-pushed
the
export-D52420921
branch
from
5586b35
to
bf8f6b9
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 4, 2024
Summary: This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Reviewed By: cipolleschi Differential Revision: D52420921
|
This pull request was exported from Phabricator. Differential Revision: D52420921 |
dmytrorykun
force-pushed
the
export-D52420921
branch
from
bf8f6b9
to
31365e6
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Jan 4, 2024
Summary: This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Reviewed By: cipolleschi Differential Revision: D52420921
|
This pull request was exported from Phabricator. Differential Revision: D52420921 |
Summary: This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Reviewed By: cipolleschi Differential Revision: D52420921
dmytrorykun
force-pushed
the
export-D52420921
branch
from
31365e6
to
2bdc6a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52420921 |
|
This pull request has been merged in ccd3b04. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42126 This diff changes how numeric types are generated for Android native modules. Before this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|double| |Double|double| |Int32|double| After this diff: |Codegen Type|Java Type| | -- | -- | |number|double| |Float|**float**| |Double|double| |Int32|**int**| Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules. `Float` -> `float`; `Int32` -> `int`. Reviewed By: cipolleschi Differential Revision: D52420921 fbshipit-source-id: 32b3bbdf5fd24db8d7ac12c262bab5fde4e1f2bc
|
This pull request has been reverted by 8a6b88e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff changes how numeric types are generated for Android native modules.
Before this diff:
Changelog: [Android][Breaking] - Codegen: mapping for numeric types is changed for Android native modules.
Float->float;Int32->int.Differential Revision: D52420921