Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem that children of textinput would be cleared when setting the selection prop #42095

Conversation

ZhuoYitao
Copy link

@ZhuoYitao ZhuoYitao commented Dec 29, 2023

Fix the problem that children of TextInput would be cleared when setting the selection prop.

Summary:

This PR Fix the problem that children of TextInput would be cleared when setting the selection prop. Here is a related issue

Changelog:

[GENERAL] [FIXED] - Fix the problem that children of TextInput would be cleared when setting the selection prop.

Test Plan:

According to logic in ReactTextInputManager.java, we should pass a null from JS to Java if we don't want to set text of TextInput.

@facebook-github-bot
Copy link
Contributor

Hi @ZhuoYitao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@ZhuoYitao ZhuoYitao changed the title Fix the problem that children of textinput would be cleared whe… Fix the problem that children of textinput would be cleared when setting the selection prop Dec 29, 2023
@ZhuoYitao ZhuoYitao force-pushed the yitao_zhuo/fix_text_input_children_clear branch from b5b278f to 231ccb8 Compare December 29, 2023 07:59
@ZhuoYitao ZhuoYitao force-pushed the yitao_zhuo/fix_text_input_children_clear branch from 231ccb8 to 513259f Compare December 29, 2023 08:24
@ZhuoYitao ZhuoYitao closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants