Add the DoubleConversion dependency to third-party libraries #41972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51848314 |
…k#41972) Summary: This diff adds the `DoubleConversion` dependency to the `install_modules_dependencies` function, that installs all the dependencies that third-party libraries might need. The libraries will need the `DoubleConversion` pod if they include the generated Fabric files. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51848314
dmytrorykun
force-pushed
the
export-D51848314
branch
from
9f14bb8
to
5c29fa6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51848314 |
|
This pull request was successfully merged by @dmytrorykun in 32dab7a. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 32dab7a. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…k#41972) Summary: Pull Request resolved: facebook#41972 This diff adds the `DoubleConversion` dependency to the `install_modules_dependencies` function, that installs all the dependencies that third-party libraries might need. The libraries will need the `DoubleConversion` pod if they include the generated Fabric files. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D51848314 fbshipit-source-id: ae2ce022c6f51ce392852494c61e26ff810d30d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the
DoubleConversiondependency to theinstall_modules_dependenciesfunction, that installs all the dependencies that third-party libraries might need.The libraries will need the
DoubleConversionpod if they include the generated Fabric files.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D51848314