Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@react-native/community-cli-plugin] Added inference of watchFolders from NPM, Yarn and PNPM workspaces #41967

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

[@react-native/community-cli-plugin] Added inference of watchFolders from NPM, Yarn and PNPM workspaces #41967

wants to merge 20 commits into from
+413 −12

Commits on Jan 30, 2024

  1. Added inference of watchFolders from NPM/Yarn workspaces

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f0c1c39 View commit details
    Browse the repository at this point in the history

  2. Adding flow types

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5f08c43 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Rob Hogan <2590098+robhogan@users.noreply.github.com>
    @kraenhansen @robhogan
    kraenhansen and robhogan committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e18e31f View commit details
    Browse the repository at this point in the history

  4. Using micromatch and removed accessSync guard

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    626625c View commit details
    Browse the repository at this point in the history

  5. Adding tests

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4afbf76 View commit details
    Browse the repository at this point in the history

  6. Fixed flow type

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    f27979c View commit details
    Browse the repository at this point in the history

  7. Moved code to the cli-plugin package

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    395b2d9 View commit details
    Browse the repository at this point in the history

  8. Using getWorkspaceRoot to supply watchFolders as a fallback

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    6c91b22 View commit details
    Browse the repository at this point in the history

  9. Provide the watchFolders override property only if project had no wat… 

    …ch folders
    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e4b8f9b View commit details
    Browse the repository at this point in the history

  10. Appending workspace root as watch folder only if not other folder tha… 

    …n the project root was given
    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9f93c7b View commit details
    Browse the repository at this point in the history

  11. Adding support for an alternative way for Yarn to declare workspaces

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    43594bd View commit details
    Browse the repository at this point in the history

  12. Adding support for PNPM workspaces

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8a734bf View commit details
    Browse the repository at this point in the history

  13. Apply suggestions from code review 

    Co-authored-by: Alex Hunt <hello@alexhunt.io>
    @kraenhansen @huntie
    kraenhansen and huntie committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2059ac2 View commit details
    Browse the repository at this point in the history

  14. Turned test file to flow

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    eca58a6 View commit details
    Browse the repository at this point in the history

  15. Apply more suggestions from code review

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    257a412 View commit details
    Browse the repository at this point in the history

  16. Using more flow without comments

    @kraenhansen
    kraenhansen committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    60b6a83 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Implemented a failing test

    @kraenhansen
    kraenhansen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d63b235 View commit details
    Browse the repository at this point in the history

  2. Updated @react-native/metro-config return MetroConfig instead of Conf… 

    …igT and remove default watchFolders
    @kraenhansen
    kraenhansen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    55fb330 View commit details
    Browse the repository at this point in the history

  3. Provide a default "undefined" override for watchFolders

    @kraenhansen
    kraenhansen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ab7816e View commit details
    Browse the repository at this point in the history

  4. Infer workspace root only if watchFolders are not explicitly specified

    @kraenhansen
    kraenhansen committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    7fd9661 View commit details
    Browse the repository at this point in the history