Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fabric: Fixes image blob url not work #41881

Closed
wants to merge 1 commit into from
Closed

[iOS] Fabric: Fixes image blob url not work #41881

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Added image blob url support.

Before:
image

After:
image

Changelog:

[IOS] [FIXED] - Fabric: Fixes image blob url not work

Test Plan:

none.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 11, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,513,055 -1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,891,832 -6
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 6e88d67
Branch: main

@facebook-github-bot
Copy link
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 12, 2023
@facebook-github-bot
Copy link
Contributor

@ryancat merged this pull request in cdef53d.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@zhongwuzw @Othinn
Fabric: Fixes image blob url not work (facebook#41881)
1405b55 
Summary:
Added image blob url support.

Before:
![image](https://github.com/facebook/react-native/assets/5061845/35835e06-1946-4cc0-9f09-ad8201c7d9b5)

After:
![image](https://github.com/facebook/react-native/assets/5061845/cde4b3cf-039c-42ba-b1d0-15e5e898df72)

## Changelog:

[IOS] [FIXED] - Fabric: Fixes image blob url not work

Pull Request resolved: facebook#41881

Test Plan: none.

Reviewed By: cortinico

Differential Revision: D52044019

Pulled By: ryancat

fbshipit-source-id: d8d8b863ddd24099ee1c2692dbe698844c0bece9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongwuzw @analysis-bot @facebook-github-bot