Fix cleanAssetCatalog error #41865
Closed
Fix cleanAssetCatalog error #41865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huntie
reviewed
Dec 11, 2023
| .filter(file => file.endsWith('.imageset')); | ||
| for (const file of files) { | ||
| fs.rmSync(path.join(catalogDir, file)); | ||
| .filter(imageSet => imageSet.endsWith('.imageset')); |
There was a problem hiding this comment.
nit: It's inaccurate to rename this to imageSet within this filter call, given these are candidates within the search directory. Let's use file or fileOrDir (which in this case is technically a file, directory, or package).
(I also don't mind the previous generic naming of files for the outer variable — until there is a future need to remove multiple kinds of files differently.)
|
@huntie Makes sense, lets just keep the current naming. |
huntie
approved these changes
Dec 12, 2023
|
@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: There is currently an error when building in release on iOS when using asset catalogs (experimental feature that is partially merged facebook#30129) This was probably incorrectly migrated from the community cli repo. `.imageset` is actually folders so it needs to be removed with `{recursive: true, force: true}`. I also renamed the variable `files` which is confusing since its folders. ## Changelog: [IOS] [FIXED] - Fix cleanAssetCatalog error Pull Request resolved: facebook#41865 Test Plan: Tested in an app that uses asset catalogs Reviewed By: NickGerleman Differential Revision: D52032258 Pulled By: huntie fbshipit-source-id: 1dc0ca09e0da0d514b03d7d72707bdcaef03301d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is currently an error when building in release on iOS when using asset catalogs (experimental feature that is partially merged #30129)
This was probably incorrectly migrated from the community cli repo.
.imagesetis actually folders so it needs to be removed with{recursive: true, force: true}. I also renamed the variablefileswhich is confusing since its folders.Changelog:
[IOS] [FIXED] - Fix cleanAssetCatalog error
Test Plan:
Tested in an app that uses asset catalogs