Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint source files, sort imports, remove unused imports #41829

Closed
wants to merge 1 commit into from
Closed

Lint source files, sort imports, remove unused imports #41829

wants to merge 1 commit into from

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Dec 7, 2023 •
edited
Loading

Summary:

This PR lints source files using eslint. I've executed yarn lint --fix and also manually fixed some of eslint issues.

Before:

CleanShot 2023-12-07 at 12 07 10@2x

After:

CleanShot 2023-12-07 at 12 06 24@2x

Changelog:

[GENERAL] [FIXED] - Lint source files, sort imports, remove unused ones

Test Plan:

CI Green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 7, 2023
@okwasniewski okwasniewski changed the title Lint source files, sort imports, remove unused ones Lint source files, sort imports, remove unused imports Dec 7, 2023
@analysis-bot
Copy link

analysis-bot commented Dec 7, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,513,627 -28
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,884,261 +16
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 186fc85
Branch: main

@facebook-github-bot
Copy link
Contributor

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 11, 2023
@facebook-github-bot
Copy link
Contributor

@dmytrorykun merged this pull request in 7d1a98c.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@okwasniewski @Othinn
Lint source files, sort imports, remove unused imports (facebook#41829)
5e9b4d3 
Summary:
This PR lints source files using eslint. I've executed `yarn lint --fix` and also manually fixed some of eslint issues.

Before:

![CleanShot 2023-12-07 at 12 07 10@2x](https://github.com/facebook/react-native/assets/52801365/2b00cf23-e5a0-46b8-802f-adcb67224111)

After:

![CleanShot 2023-12-07 at 12 06 24@2x](https://github.com/facebook/react-native/assets/52801365/bb05b2c0-2b27-4f99-b7b4-cb47a51a3885)

## Changelog:

[GENERAL] [FIXED] - Lint source files, sort imports, remove unused ones

Pull Request resolved: facebook#41829

Test Plan: CI Green

Reviewed By: christophpurrer

Differential Revision: D51979074

Pulled By: dmytrorykun

fbshipit-source-id: e11b90721e33f5e9949a0833e5f39fe7ba3d1067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okwasniewski @analysis-bot @facebook-github-bot