Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert ReactPropForShadowNodeSetterTest to kotlin #41774

Closed
wants to merge 3 commits into from

Conversation

moskalakamil
Copy link
Contributor

Summary:

This PR convert ReactPropForShadowNodeSetterTest to kotlin as part of #38825

Changelog:

[INTERNAL] [CHANGED] - Convert ReactPropForShadowNodeSetterTest to kotlin

Test Plan:

./gradlew :packages:react-native:ReactAndroid:test

@facebook-github-bot
Copy link
Contributor

Hi @moskalakamil!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@moskalakamil
Copy link
Contributor Author

moskalakamil commented Dec 3, 2023

I converted test to kotlin but I wasn't able to fix the Yoga error - that's why I left it Ignored (similar issues here and here).
I would be pleasure for yours review @cortinico and @mdvacca

@analysis-bot
Copy link

analysis-bot commented Dec 3, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,745,740 -24,938
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,116,555 -24,669
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: db609ff
Branch: main

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 3, 2023
@cortinico
Copy link
Contributor

Please see this PR where I fixed the tests. You should ideally rebase your Koltin convertion on top of it #41788

@moskalakamil
Copy link
Contributor Author

Please see this PR where I fixed the tests. You should ideally rebase your Koltin convertion on top of it #41788

hey @cortinico, I cherry-picked your commit locally and it seems to work!
image
I will wait once it land and I'll rebase on top of the main

@cortinico
Copy link
Contributor

Great I'll convert this to draft for now. Let's wait for the other diff to land and we can rebase/import this one

@cortinico cortinico marked this pull request as draft December 5, 2023 13:17
@cortinico cortinico marked this pull request as ready for review December 5, 2023 15:28
@cortinico
Copy link
Contributor

@moskalakamil please rebase and ping me when you're done. The CI should also be green before we can merge this

@moskalakamil
Copy link
Contributor Author

@cortinico NetworkingModuleTest fails on main, I would be grateful for quick fix

@cortinico
Copy link
Contributor

@cortinico NetworkingModuleTest fails on main, I would be grateful for quick fix

Yes we're aware of it. @rshest is working on a fix that will be out soon.

@moskalakamil
Copy link
Contributor Author

moskalakamil commented Dec 6, 2023

Hey @cortinico, I'm done

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@moskalakamil
Copy link
Contributor Author

@cortinico I forgot to remove java test after rebase, now everything is fine

@github-actions github-actions bot added the Merged This PR has been merged. label Dec 7, 2023
Copy link

github-actions bot commented Dec 7, 2023

This pull request was successfully merged by @moskalakamil in 186fc85.

When will my fix make it into a release? | Upcoming Releases

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…k#41774)

Summary:
This PR convert `ReactPropForShadowNodeSetterTest` to kotlin as part of facebook#38825

## Changelog:

[INTERNAL] [CHANGED] - Convert ReactPropForShadowNodeSetterTest to kotlin

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests

Pull Request resolved: facebook#41774

Test Plan:
```
./gradlew :packages:react-native:ReactAndroid:test
```

Reviewed By: NickGerleman

Differential Revision: D51882685

Pulled By: cortinico

fbshipit-source-id: ff1cce824dc342200f1f5ccbb297b955747b10c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants