-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert ReactPropForShadowNodeSetterTest to kotlin #41774
Conversation
Hi @moskalakamil! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
I converted test to kotlin but I wasn't able to fix the Yoga error - that's why I left it Ignored (similar issues here and here). |
Base commit: db609ff |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Please see this PR where I fixed the tests. You should ideally rebase your Koltin convertion on top of it #41788 |
hey @cortinico, I cherry-picked your commit locally and it seems to work! |
Great I'll convert this to draft for now. Let's wait for the other diff to land and we can rebase/import this one |
@moskalakamil please rebase and ping me when you're done. The CI should also be green before we can merge this |
@cortinico |
Yes we're aware of it. @rshest is working on a fix that will be out soon. |
Hey @cortinico, I'm done |
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@cortinico I forgot to remove java test after rebase, now everything is fine |
This pull request was successfully merged by @moskalakamil in 186fc85. When will my fix make it into a release? | Upcoming Releases |
…k#41774) Summary: This PR convert `ReactPropForShadowNodeSetterTest` to kotlin as part of facebook#38825 ## Changelog: [INTERNAL] [CHANGED] - Convert ReactPropForShadowNodeSetterTest to kotlin <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook#41774 Test Plan: ``` ./gradlew :packages:react-native:ReactAndroid:test ``` Reviewed By: NickGerleman Differential Revision: D51882685 Pulled By: cortinico fbshipit-source-id: ff1cce824dc342200f1f5ccbb297b955747b10c8
Summary:
This PR convert
ReactPropForShadowNodeSetterTest
to kotlin as part of #38825Changelog:
[INTERNAL] [CHANGED] - Convert ReactPropForShadowNodeSetterTest to kotlin
Test Plan: