Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Fabric Interop Layer automatic #41656

Closed
wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:
This change makes all the legacy components to go through the interop layer.
It also introduce the RCTFabricInteropLayerEnabled() and the RCTEnableFabricInteropLayer(BOOL) functions to work as feature flags behind the change to completely disable the Interop layer.

Changelog

[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Differential Revision: D51586461

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

@analysis-bot
Copy link

analysis-bot commented Nov 27, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,525,141 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,899,941 -7
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 289e783
Branch: main

cipolleschi pushed a commit to cipolleschi/react-native that referenced this pull request Nov 27, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Differential Revision: D51586461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Dec 14, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Dec 14, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Dec 14, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Dec 18, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request Dec 18, 2023
Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

Summary:

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51586461

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 18, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 27f38f6.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41656

This change makes all the legacy components to go through the interop layer.
It also introduce the `RCTFabricInteropLayerEnabled()` and the `RCTEnableFabricInteropLayer(BOOL)` functions to work as feature flags behind the change to completely disable the Interop layer.

## Changelog
[iOS][Changed] - Make the Fabric Interop Layer automatic when the Nw architecture is enabled.

Reviewed By: cortinico

Differential Revision: D51586461

fbshipit-source-id: 8f92a76e6dbbee93055a1ebe49779dd64e484d95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants