Skip to content

filter out yoga style props during folly::dynamic conversion #41607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sammy-SC
Copy link
Contributor

Summary: changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

@analysis-bot
Copy link

analysis-bot commented Nov 22, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,670,599 +4,079
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,053,832 +4,098
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e441b06
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

sammy-SC added a commit to sammy-SC/hermes that referenced this pull request Nov 23, 2023
…k#1198)

Summary:
X-link: facebook/react-native#41607


changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Nov 23, 2023
…k#41607)

Summary:

X-link: facebook/hermes#1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

sammy-SC added a commit to sammy-SC/hermes that referenced this pull request Nov 23, 2023
…k#1198)

Summary:
X-link: facebook/react-native#41607


changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Nov 23, 2023
…k#41607)

Summary:

X-link: facebook/hermes#1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

sammy-SC added a commit to sammy-SC/hermes that referenced this pull request Nov 24, 2023
…k#1198)

Summary:
X-link: facebook/react-native#41607


changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Nov 24, 2023
…k#41607)

Summary:

X-link: facebook/hermes#1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
…k#41607)

Summary:

X-link: facebook/hermes#1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
sammy-SC added a commit to sammy-SC/hermes that referenced this pull request Nov 24, 2023
…k#1198)

Summary:
X-link: facebook/react-native#41607


changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51471665

facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Nov 24, 2023
Summary:
X-link: facebook/react-native#41607

Pull Request resolved: #1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665

fbshipit-source-id: 0633422d356c2f2419ea87b2a2ad6b5ea64c99f6
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 67c852e.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…k#41607)

Summary:
Pull Request resolved: facebook#41607

X-link: facebook/hermes#1198

changelog: [internal]

Reviewed By: javache

Differential Revision: D51471665

fbshipit-source-id: 0633422d356c2f2419ea87b2a2ad6b5ea64c99f6
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Jan 18, 2024
…1198)

Summary:
Original Author: samuelsusla@meta.com
Original Git: d909836
Original Reviewed By: javache
Original Revision: D51471665

X-link: facebook/react-native#41607

Pull Request resolved: #1198

changelog: [internal]

Reviewed By: tmikov

Differential Revision: D52854379

fbshipit-source-id: 590d081f52cb616a1d44a328371d33483b22c016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants