Remove some usages of RCT_NEW_ARCH_ENABLED #41589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
Base commit: 2a4338d |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
cipolleschi
force-pushed
the
export-D51498730
branch
from
5f95cd6
to
2b86526
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
cipolleschi
force-pushed
the
export-D51498730
branch
from
2b86526
to
2b995ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
cipolleschi
force-pushed
the
export-D51498730
branch
from
2b995ad
to
e8fe35b
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
cipolleschi
force-pushed
the
export-D51498730
branch
from
e8fe35b
to
580736e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
added 4 commits
November 22, 2023 02:48
Summary: The RN_FABRIC_ENABLED has been deprecated and superseded by the RCT_NEW_ARCH_ENABLED for a while now. This change removes it, from the codebase as now we always have the Fabric pod available to the codebase. ## Changelog [Internal] - Remove RN_FABRIC_ENABLED flag Reviewed By: dmytrorykun Differential Revision: D51468332
Summary: This change remove a flag that is unused. ## Changelog [Internal] - Remove unused Flag Reviewed By: dmytrorykun Differential Revision: D51493765
Summary: This change always installs all the Pods for both architecture. This unify the behavior between iOS and Android. ## Changelog: [Internal] - Always install all the pods ## Facebook: The inly four pods that are changed when flipping between the new and the old arch with RNTester are: - MyNativeView - NativeCxxModuleExample - React-RCTAppDelegate - ScreenshotManager The only change there is the RCt_NEW_ARCH_ENABLED flag being set or not in those pods Reviewed By: dmytrorykun Differential Revision: D51494498
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 22, 2023
Summary: This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730
cipolleschi
force-pushed
the
export-D51498730
branch
from
580736e
to
38a111f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
cipolleschi
force-pushed
the
export-D51498730
branch
from
38a111f
to
f6bfadc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51498730 |
|
This pull request has been merged in 951efc8. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41589 This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED. Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not. This change will not alter the behavior of the app. ## Changelog: [iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some **Swift** libraries might get broken by this change. Reviewed By: dmytrorykun Differential Revision: D51498730 fbshipit-source-id: c83416480eea1f7bbc55f72c31e7b69ad0e9e01a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a cleanup diffs that removes some of the usages of RCT_NEW_ARCH_ENABLED.
Now that we are shipping all the pods, there is no need to conditionally compile-out part of the codebase depending on whether the new architecture is running or not.
This change will not alter the behavior of the app.
Changelog:
[iOS][Breaking] - Remove some usages of RCT_NEW_ARCH_ENABLED. The change should be transparent BUT some Swift libraries might get broken by this change.
Differential Revision: D51498730