Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageManager implementation overridable #41582

Closed
wants to merge 1 commit into from

Conversation

rshest
Copy link
Contributor

@rshest rshest commented Nov 21, 2023

Summary:

Changelog:

This will allow to have custom ImageManager implementations on new platforms.

Differential Revision: D51495143

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51495143

@analysis-bot
Copy link

analysis-bot commented Nov 21, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,667,330 -6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,050,615 -13
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 7625a50
Branch: main

rshest added a commit to rshest/react-native that referenced this pull request Nov 21, 2023
Summary:

# Changelog:

This will allow to have custom `ImageManager` implementations on new platforms.

Differential Revision: D51495143
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51495143

Summary:

# Changelog:

This will allow to have custom `ImageManager` implementations on new platforms.

Reviewed By: christophpurrer

Differential Revision: D51495143
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51495143

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 21, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ac1cdaa.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41582

# Changelog:

This will allow to have custom `ImageManager` implementations on new platforms.

Reviewed By: christophpurrer

Differential Revision: D51495143

fbshipit-source-id: bbd03bdad1b87fd53e70a886f1fdc74f371987c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants