[RN-Tester] Fix assert cxx example crash the app when tap Run all tests
#41521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
approved these changes
Nov 17, 2023
|
This pull request was successfully merged by @zhongwuzw in 02bb50d. When will my fix make it into a release? | Upcoming Releases |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…ok#41521) Summary: When I tap the `Run all tests` button in CxxModuleExample, App crashed because our `assert` examples directoly.  I moved the error report examples to individual section so `Run all tests` not crash.  ## Changelog: [INTERNAL] [FIXED] - [RN-Tester] Fix assert cxx example crash the app when tap `Run all tests` Pull Request resolved: facebook#41521 Test Plan: None. Reviewed By: christophpurrer Differential Revision: D51423538 Pulled By: rshest fbshipit-source-id: 1e2844aa9011de4476ec4b134d43daa3260a73d5
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 19, 2024
Summary: Same as facebook#41521 for the Java / ObjC Turbo Module example. [INTERNAL] [FIXED] - [RN-Tester] Fix assert Turbo Module example crash the app when tap `Run all tests` Differential Revision: D57531736
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 19, 2024
facebook#44607) Summary: Same as facebook#41521 for the Java / ObjC Turbo Module example. [INTERNAL] [FIXED] - [RN-Tester] Fix assert Turbo Module example crash the app when tap `Run all tests` Differential Revision: D57531736
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
May 20, 2024
facebook#44607) Summary: Same as facebook#41521 for the Java / ObjC Turbo Module example. [INTERNAL] [FIXED] - [RN-Tester] Fix assert Turbo Module example crash the app when tap `Run all tests` Differential Revision: D57531736
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2024
#44607) Summary: Pull Request resolved: #44607 Same as #41521 for the Java / ObjC Turbo Module example. Changelog: [INTERNAL] [FIXED] - [RN-Tester] Fix assert Turbo Module example crash the app when tap `Run all tests` Reviewed By: cortinico Differential Revision: D57531736 fbshipit-source-id: 7cad5dfd31c306dff4763b67466664f2dde6b239
kosmydel
pushed a commit
to kosmydel/react-native
that referenced
this pull request
Jun 11, 2024
facebook#44607) Summary: Pull Request resolved: facebook#44607 Same as facebook#41521 for the Java / ObjC Turbo Module example. Changelog: [INTERNAL] [FIXED] - [RN-Tester] Fix assert Turbo Module example crash the app when tap `Run all tests` Reviewed By: cortinico Differential Revision: D57531736 fbshipit-source-id: 7cad5dfd31c306dff4763b67466664f2dde6b239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When I tap the
Run all testsbutton in CxxModuleExample, App crashed because ourassertexamples directoly.I moved the error report examples to individual section so
Run all testsnot crash.Changelog:
[INTERNAL] [FIXED] - [RN-Tester] Fix assert cxx example crash the app when tap
Run all testsTest Plan:
None.