Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put PR#41194 behind gating #41469

Closed
wants to merge 1 commit into from
Closed

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Nov 13, 2023

Summary:
Changelog: [Internal]

PR#41194 (#41194) introduces a new callsite to RCTUnsafeExecuteOnMainQueueSync in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 13, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 13, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
philIip added a commit to philIip/react-native that referenced this pull request Nov 13, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

philIip added a commit to philIip/react-native that referenced this pull request Nov 14, 2023
Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

Summary:

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51274859

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8feb84a.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41469

Changelog: [Internal]

PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it

Differential Revision: D51274859

fbshipit-source-id: b2ab6d42378d2885def1fdad61e1de0f6e6285cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants