Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type in BlobCollector.h/cpp #41404

Closed
wants to merge 1 commit into from
Closed

Fix type in BlobCollector.h/cpp #41404

wants to merge 1 commit into from

Conversation

Sunbreak
Copy link
Contributor

When working on JSI module, BlobCollector's nativeInstall is a good example. But the first type should be jni::alias_ref<jclass> according to https://github.com/facebookincubator/fbjni/blob/main/docs/quickref.md#basic-method-usage-java-to-c-and-c-to-java

Summary:

Fix type in BlobCollector.h/cpp

Changelog:

[ANDROID] [FIXED] - Fix type in BlobCollector.h/cpp

Test Plan:

None

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 10, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,653,688 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,033,654 +1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c2ac0cc
Branch: main

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in c267a06.

@Sunbreak Sunbreak deleted the fix-blob-type branch November 11, 2023 00:30
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@Sunbreak @Othinn
Fix type in BlobCollector.h/cpp (facebook#41404)
fda9781 
Summary:
When working on JSI module, `BlobCollector`'s `nativeInstall` is a good example. But the first type should be `jni::alias_ref<jclass>` according to https://github.com/facebookincubator/fbjni/blob/main/docs/quickref.md#basic-method-usage-java-to-c-and-c-to-java

Fix type in BlobCollector.h/cpp

## Changelog:

[ANDROID] [FIXED] - Fix type in BlobCollector.h/cpp

Pull Request resolved: facebook#41404

Test Plan: None

Reviewed By: cipolleschi

Differential Revision: D51198049

Pulled By: javache

fbshipit-source-id: 86f471cbe3cd683a7be605ce127b3b3c3769c037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sunbreak @analysis-bot @facebook-github-bot