Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DefaultReactNativeHost to use the new way of Fabric initialization #41374

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
Refactoring DefaultReactNativeHost to use the new way of Fabric initialization through FabricUIManagerProviderImpl

Changelog:
[Internal] internal

Differential Revision: D50926872

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50926872

@analysis-bot
Copy link

analysis-bot commented Nov 8, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,653,676 -17
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,033,651 -2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: c2ac0cc
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50926872

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50926872

arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Nov 8, 2023
…zation (facebook#41374)

Summary:

Refactoring `DefaultReactNativeHost` to use the new way of Fabric initialization through `FabricUIManagerProviderImpl`

Changelog:
[Internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D50926872
@arushikesarwani94 arushikesarwani94 force-pushed the export-D50926872 branch 2 times, most recently from af07837 to cafd03d Compare November 8, 2023 17:22
arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Nov 8, 2023
…zation (facebook#41374)

Summary:

Refactoring `DefaultReactNativeHost` to use the new way of Fabric initialization through `FabricUIManagerProviderImpl`

Changelog:
[Internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D50926872
arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Nov 10, 2023
…zation (facebook#41374)

Summary:

Refactoring `DefaultReactNativeHost` to use the new way of Fabric initialization through `FabricUIManagerProviderImpl`

Changelog:
[Internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D50926872
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50926872

…of JSIModule (facebook#41313)

Summary:

Refactor ReactNativeHost, ReactInstanceManager & Builder of `react-native-github` to use the new way of fabric initialization using the newly added class `FabricUIManagerProviderImpl.java` instead of JSIModule and thereby also refactoring the call site in FbReactInstanceHolder.java

Changelog:
[Internal] internal

Reviewed By: philIip

Differential Revision: D50783751
Summary:

Refactor `ReactNativeHost` to add the APIs for `UIManagerProvider`.

Reviewed By: christophpurrer, philIip

Differential Revision: D51120159
…zation (facebook#41374)

Summary:

Refactoring `DefaultReactNativeHost` to use the new way of Fabric initialization through `FabricUIManagerProviderImpl`

Changelog:
[Internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D50926872
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50926872

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 10, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in eb3ee4d.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by f53bd56.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…zation (facebook#41374)

Summary:
Pull Request resolved: facebook#41374

Refactoring `DefaultReactNativeHost` to use the new way of Fabric initialization through `FabricUIManagerProviderImpl`

Changelog:
[Internal] internal

Reviewed By: philIip, luluwu2032

Differential Revision: D50926872

fbshipit-source-id: be2bcea7b2ce7cb1b3f903dc92fcd2c91be267da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants