Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lint/sort-imports everywhere #41334

Closed
wants to merge 2 commits into from

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Nov 6, 2023

Summary:
TSIA.

Changelog: [Internal]

Differential Revision: D51025812

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Nov 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51025812

Copy link

github-actions bot commented Nov 6, 2023

Warnings
⚠️

jest/preprocessor.js#L15 - jest/preprocessor.js line 15 – 'lint/sort-imports' rule is disabled but never reported. (eslint-comments/no-unused-disable)

⚠️

packages/react-native-bots/dangerfile.js#L107 - packages/react-native-bots/dangerfile.js line 107 – 'handleStatuses' is defined but never used. (no-unused-vars)

⚠️

packages/react-native/ReactAndroid/src/androidTest/js/TestBundle.js#L12 - packages/react-native/ReactAndroid/src/androidTest/js/TestBundle.js line 12 – 'lint/sort-imports' rule is disabled but never reported. (eslint-comments/no-unused-disable)

⚠️

packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js#L284 - packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 284 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)

⚠️

packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js#L288 - packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 288 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)

⚠️

packages/rn-tester/js/examples/TextInput/TextInputExample.android.js#L473 - packages/rn-tester/js/examples/TextInput/TextInputExample.android.js line 473 – 'examples' is already declared in the upper scope on line 155 column 7. (no-shadow)

⚠️

packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js#L354 - packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js line 354 – 'examples' is already declared in the upper scope on line 326 column 7. (no-shadow)

⚠️

packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js#L397 - packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js line 397 – 'examples' is already declared in the upper scope on line 326 column 7. (no-shadow)

⚠️

packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js#L423 - packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js line 423 – 'examples' is already declared in the upper scope on line 326 column 7. (no-shadow)

⚠️

packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js#L499 - packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js line 499 – 'examples' is already declared in the upper scope on line 326 column 7. (no-shadow)

Generated by 🚫 dangerJS against d7db97a

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51025812

motiz88 added a commit to motiz88/react-native that referenced this pull request Nov 6, 2023
Summary:
Pull Request resolved: facebook#41334

TSIA.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D51025812

fbshipit-source-id: 05952a518441b9befc1c84686e34a808b8001cc5
@analysis-bot
Copy link

analysis-bot commented Nov 6, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,634,308 -2,306
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,018,059 -295
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d09c02f
Branch: main

Differential Revision: D51025811

fbshipit-source-id: 03f5f15add2f98a02755185e13e474b8102a427e
Summary:
Pull Request resolved: facebook#41334

TSIA.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D51025812

fbshipit-source-id: 5fee5fa1d9325bb6e67c55a2c1df6c96d7e69002
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51025812

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d6e0bc7.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#41334

TSIA.

Changelog: [Internal]

Reviewed By: robhogan

Differential Revision: D51025812

fbshipit-source-id: e10d437be775a6b80946483aa96460f34927f870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants