Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed types props tabIndex in view #41312

Closed
wants to merge 1 commit into from
Closed

fix: fixed types props tabIndex in view #41312

wants to merge 1 commit into from

Conversation

wootsbot
Copy link
Contributor

@wootsbot wootsbot commented Nov 3, 2023 •
edited
Loading

Summary:

@zfrankdesign reported that in RN 0.72.6, they receive warnings that some new props listed in the documents are missing:
View tabIndex https://reactnative.dev/docs/view#tabindex-android. It seems the components accept these props but they were not typed.

Changelog:

[GENERAL] [FIXED] - Missing typings for the props tabIndex for View

Test Plan:

  1. Instantiate a component of type View
    1.1. Should add the property tabIndex to the View component.
    1.2. Should not see a warning about the missing tabIndex property.

@facebook-github-bot
Copy link
Contributor

Hi @wootsbot!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@wootsbot wootsbot mentioned this pull request Nov 3, 2023
Closed
@tarunrajput
Copy link
Contributor

userSelect is a Text style prop and is incorrectly listed under Text Props.I have opened a PR (facebook/react-native-website#3913) to the website to fix this
cc: @lunaleaps

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 3, 2023
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman
Copy link
Contributor

Not seeing userSelect as mentioned in the description in the list of files. Forgot to stage?

@wootsbot wootsbot changed the title fix: fixed types props tabIndex in view and userSelect in text fix: fixed types props tabIndex in view Nov 3, 2023
@wootsbot
Copy link
Contributor Author

wootsbot commented Nov 3, 2023

Not seeing userSelect as mentioned in the description in the list of files. Forgot to stage?

I have changed the description and the commit message In favor of what @tarunrajput mentions here. #41312 (comment).

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Nov 4, 2023
@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in b36505b.

@wootsbot wootsbot deleted the fix/types-view-and-text branch November 4, 2023 06:00
@TatianaKapos TatianaKapos mentioned this pull request Dec 22, 2023
Merged
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@wootsbot @Othinn
fix: fixed types props tabIndex in view and userSelect in text (faceb…
7ba8528 
…ook#41312)

Summary:
zfrankdesign reported that in RN 0.72.6, they receive warnings that some new props listed in the documents are missing:
View tabIndex https://reactnative.dev/docs/view#tabindex-android and Text userSelect https://reactnative.dev/docs/text#userselect. It seems the components accept these props but they were not typed.

## Changelog:

[GENERAL] [FIXED] - Missing typings for the props `tabIndex` for **View** and `userSelect` in the **Text** props were added.

Pull Request resolved: facebook#41312

Test Plan:
1. Instantiate a component of type View
   1.1. Should add the property tabIndex to the View component.
   1.2. Should not see a warning about the missing tabIndex property.

2. Instantiate a component of type Text
   2.1. Should add the property userSelect to the Text component.
   2.2. Should not see a warning about the missing userSelect property.

Reviewed By: NickGerleman

Differential Revision: D50982156

Pulled By: lunaleaps

fbshipit-source-id: 75b55cfb897738be0cf426912a7c10c7412d5032
@TatianaKapos TatianaKapos mentioned this pull request Nov 6, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunrajput tarunrajput Awaiting requested review from tarunrajput

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wootsbot @facebook-github-bot @tarunrajput @NickGerleman