Configure Java toolchains per project #41306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Nov 3, 2023
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 80d816a |
|
Wait... This fix is having issue on old arch... |
|
Libraries on old arch does not apply the RNGP, and will not get their Java toolchains configured. Therefore, this PR is inapplicable. Closing it for now. |
EDIT: You were right. This is a bug (see #41620). Fix is forthcoming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A follow-up fix on #40560
The fix introduced by #40757 worked under the false assumption that
:appgets evaluated before any other library. However, some libraries, such as @amplitude/analytics-react-native (whose project name is:amplitude_analytics-react-native), might be evaluated before:appand miss theconfigureJavaToolChains()process.This PR changes
configureJavaToolChains()into a per-project implementation, and invokes the function during both library and app configurations. This can ensure that all projects get their Java toolchains configured promptly.Changelog:
[ANDROID] [FIXED] - Configure Java toolchains per project
Test Plan:
Test with @amplitude/analytics-react-native and ensure that the android app builds in new arch.