Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test Windows (0.73) #41279

Closed
wants to merge 1 commit into from
Closed

Fix Test Windows (0.73) #41279

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Nov 1, 2023 •
edited
Loading

Summary

This PR fixes the test_windows in 0.73 after node has moved to 20 as LTS

Changelog:

[Internal] - Fix test_windows by using the right Node

Test Plan:

CircleCI is back to green.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.73-stable November 1, 2023 11:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023 •
edited
Loading

Fails
🚫

❗ Base Branch - The base branch for this PR is something other than main or a -stable branch. Are you sure you want to target something other than the main branch?
Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 3256eed

@cipolleschi cipolleschi changed the base branch from 0.73-stable to cipolleschi/fix-node-on-debian November 1, 2023 11:46
@cipolleschi cipolleschi closed this Nov 1, 2023
@cortinico cortinico deleted the cipolleschi/fix-windows-tests-073 branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipolleschi @facebook-github-bot