Refactor BaseJavaModule and ReactContextBaseJavaModule #39823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49930340 |
Base commit: ec1de61 |
|
This pull request was exported from Phabricator. Differential Revision: D49930340 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 5, 2023
Summary: Pull Request resolved: facebook#39823 In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy. ReactContextBaseJavaModule will be deprecated in the new architecture Reviewed By: cortinico Differential Revision: D49930340 fbshipit-source-id: 695f4267c1409d67b8a63d5609f02d4b50e18567
mdvacca
force-pushed
the
export-D49930340
branch
from
7920442
to
bb7a553
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49930340 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 9, 2023
Summary: Pull Request resolved: facebook#39823 In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy. ReactContextBaseJavaModule will be deprecated in the new architecture bypass-github-export-checks Reviewed By: cortinico Differential Revision: D49930340 fbshipit-source-id: 965316211023cb1db1f7ac7e3af292e84cc2ea43
mdvacca
force-pushed
the
export-D49930340
branch
from
bb7a553
to
37ea73b
Compare
…itecture Summary: In this diff I'm marking NativeModule.canOverrideExistingModule() as DeprecatedInNewArchitecture. changelog: [internal] internal Differential Revision: D49930341 fbshipit-source-id: 59d57924ddff8d5bdd2dfcb4cdd0ebb986d5efb0
Summary: Update documentation of NativeModule methods changelog: [internal] internal Differential Revision: D49930342 fbshipit-source-id: 860ac74f8ae03baed5e2c52831b4e3011424dceb
|
This pull request was exported from Phabricator. Differential Revision: D49930340 |
Summary: Pull Request resolved: facebook#39823 In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy. ReactContextBaseJavaModule will be deprecated in the new architecture bypass-github-export-checks Reviewed By: cortinico Differential Revision: D49930340 fbshipit-source-id: c56fda685382a8f5cf549533687c9c9bb843316b
mdvacca
force-pushed
the
export-D49930340
branch
from
37ea73b
to
c2bf3e4
Compare
|
This pull request has been merged in 5af7b70. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.
ReactContextBaseJavaModule will be deprecated in the new architecture
Reviewed By: cortinico
Differential Revision: D49930340