Reduce visibility of JSIModuleRegistry. #39740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39740 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Reviewed By: RSNara Differential Revision: D49752138 fbshipit-source-id: 2f95a7dafc340a982779699216036347b9159f93
mdvacca
force-pushed
the
export-D49752138
branch
from
84d4a49
to
2d99037
Compare
Base commit: 294c0fa |
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39740 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Reviewed By: RSNara Differential Revision: D49752138 fbshipit-source-id: c36deaaf6c6796159258f33afc15cea821b490f0
mdvacca
force-pushed
the
export-D49752138
branch
from
2d99037
to
df0414a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39740 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Reviewed By: RSNara Differential Revision: D49752138 fbshipit-source-id: 40a9830ae50d8920c917c977c1a3ce6336fb1334
mdvacca
force-pushed
the
export-D49752138
branch
from
df0414a
to
3ac4465
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39740 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Reviewed By: RSNara Differential Revision: D49752138 fbshipit-source-id: f940f4888afa16851dc3060f038e28c4701c952f
mdvacca
force-pushed
the
export-D49752138
branch
from
3ac4465
to
dcaaecc
Compare
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromArray Differential Revision: D49752134 fbshipit-source-id: 802a1892d6493c3d35bd93e5746ae236a464a7df
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Differential Revision: D49752137 fbshipit-source-id: 6c0eaa6a6ae725e7487df70974cee1bcd812172d
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Differential Revision: D49752141 fbshipit-source-id: 06b422be6c94cda6a1d75203bf73449e073b1094
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleHolder Differential Revision: D49752136 fbshipit-source-id: cd312814e98a0a75921b9875846b370a0d78ece8
|
This pull request was exported from Phabricator. Differential Revision: D49752138 |
Summary: Pull Request resolved: facebook#39740 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Reviewed By: RSNara Differential Revision: D49752138 fbshipit-source-id: eb6fba78d6ea8c9398353a3133fc40de90c05107
mdvacca
force-pushed
the
export-D49752138
branch
from
dcaaecc
to
39d572c
Compare
|
This pull request has been merged in e3e9b13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry.
Reviewed By: RSNara
Differential Revision: D49752138