Reduce visibility of JSInstance #39738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39738 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Reviewed By: RSNara Differential Revision: D49752139 fbshipit-source-id: bd06f4edfe01b4b05fa97dcaa0fc2a6584a8835a
mdvacca
force-pushed
the
export-D49752139
branch
from
cff267f
to
b924abc
Compare
Base commit: 294c0fa |
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39738 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Reviewed By: RSNara Differential Revision: D49752139 fbshipit-source-id: 1e436b9745969d2a9053af77959e663b77c0a847
mdvacca
force-pushed
the
export-D49752139
branch
from
b924abc
to
c494f59
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39738 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Reviewed By: RSNara Differential Revision: D49752139 fbshipit-source-id: cde2f37262d10f044d29968e67f619cb95648189
mdvacca
force-pushed
the
export-D49752139
branch
from
c494f59
to
e82b7a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Oct 1, 2023
Summary: Pull Request resolved: facebook#39738 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Reviewed By: RSNara Differential Revision: D49752139 fbshipit-source-id: c2232e6094dbbf9cc2d9f5d18fac8b1c13b54876
mdvacca
force-pushed
the
export-D49752139
branch
from
e82b7a2
to
fafa34f
Compare
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromArray Differential Revision: D49752134 fbshipit-source-id: 985af310528597fc5489226d7b24251ef1797a0b
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of DynamicFromMap Differential Revision: D49752137 fbshipit-source-id: 41be7311b20a7e718e53a6ae3350612a9907b9d4
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSCJavaScriptExecutorFactory Differential Revision: D49752141 fbshipit-source-id: 8efa81fdd189fda27bae50387ce3680cc7341fce
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleHolder Differential Revision: D49752136 fbshipit-source-id: 396dd5cb73562cd0d041023380a4404d72b85172
Summary: In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSIModuleRegistry. Differential Revision: D49752138 fbshipit-source-id: ed5ba6f1e8763a2d2be6cc5d5c46e05a91a43e93
|
This pull request was exported from Phabricator. Differential Revision: D49752139 |
Summary: Pull Request resolved: facebook#39738 In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages. As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages. If you are using this class or interface please comment in this PR and we will restate the public access. changelog: [Android][Changed] Reducing visibility of JSInstance Reviewed By: RSNara Differential Revision: D49752139 fbshipit-source-id: c8381ab45b0e881b570c60518cce304827f87b54
mdvacca
force-pushed
the
export-D49752139
branch
from
fafa34f
to
d49faff
Compare
|
This pull request has been merged in d224816. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of JSInstance
Reviewed By: RSNara
Differential Revision: D49752139