Remove support for Android API < 23 in WindowOverlayCompat #39673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 7f0f55429513455b1b710ad4b7b2b61402d7f04a
mdvacca
force-pushed
the
export-D48545505
branch
from
838ef52
to
3cf0d82
Compare
Base commit: 5203354 |
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 07a3df7525607598cf7793465efd7cb442706530
mdvacca
force-pushed
the
export-D48545505
branch
from
3cf0d82
to
bdc2ba7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 22956675a40027c108bb13eea1aa37ca548c3c0c
mdvacca
force-pushed
the
export-D48545505
branch
from
bdc2ba7
to
047d345
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 0a61a032908838cdf30165f321dbd356fc0a0fca
mdvacca
force-pushed
the
export-D48545505
branch
from
047d345
to
a54c12e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 2806530a69c97dca79a0b012f5d3aec67ade70e0
mdvacca
force-pushed
the
export-D48545505
branch
from
a54c12e
to
83d2596
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: a9d925ea91bdb4ce9481900f0586d1df810cc528
mdvacca
force-pushed
the
export-D48545505
branch
from
83d2596
to
613ed41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat changelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: 4c5eb9637a2b8cdb25adbe2320077653cd9207c5
mdvacca
force-pushed
the
export-D48545505
branch
from
613ed41
to
b86b021
Compare
Summary: In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk changelog: [Android][Breaking] Increase min sdk version of RN Android to 23 Differential Revision: D48177965 fbshipit-source-id: 526e3490743b22d9de013513a7b61ec192af873e
Summary: Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in chnagelog: [Android][Breaking] Remove support for Android API < 23 in Differential Revision: D48545501 fbshipit-source-id: aef7781120417d1ec1b25e9ebbb2a254cb24436f
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment Differential Revision: D48545506 fbshipit-source-id: 22bd3a29b68dbebf3ff9b69f6fc4ad7fb01795b4
Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class DebugOverlayController chnagelog: [Android][Breaking] Remove support for Android API < 23 in DebugOverlayController Differential Revision: D48545520 fbshipit-source-id: 8eedbf5cfd4bd4e20878988266a9c2d92f227d88
|
This pull request was exported from Phabricator. Differential Revision: D48545505 |
…39673) Summary: Pull Request resolved: facebook#39673 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat changelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat Reviewed By: NickGerleman Differential Revision: D48545505 fbshipit-source-id: d7f5686922694210de3ec9081f640eee7ffe84a6
mdvacca
force-pushed
the
export-D48545505
branch
from
b86b021
to
63938ee
Compare
|
This pull request has been merged in c359a44. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat
chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat
Reviewed By: NickGerleman
Differential Revision: D48545505